Sync cloud integration on Authorization problems #4324
+26
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeibbb
changed the title
sergeibbb
force-pushed
the
sync-cloud-integration-on-auth-problems
branch
from
eb468fa to
fd28d05
Compare
sergeibbb
added a commit
that referenced
this pull request
May 21, 2025
sergeibbb
added a commit
that referenced
this pull request
May 22, 2025
sergeibbb
force-pushed
the
sync-cloud-integration-on-auth-problems
branch
from
fd28d05 to
500523d
Compare
sergeibbb
added a commit
that referenced
this pull request
May 23, 2025
sergeibbb
force-pushed
the
sync-cloud-integration-on-auth-problems
branch
from
500523d to
3ce2c47
Compare
sergeibbb
force-pushed
the
sync-cloud-integration-on-auth-problems
branch
from
3ce2c47 to
c962bd0
Compare
Comment on lines
+287
to
+291
| this.syncCountDueToRequestException++; | ||
| this._session = { | ||
| ...this._session, | ||
| expiresAt: new Date(Date.now() - 1), | ||
| }; |
There was a problem hiding this comment.
I have a hypothetical scenario I want to check with you here.
Let's say I have a GitHub token which has the required scopes to get my current account but not the scopes to get PRs.
So, every time the Launchpad automatically fetches PRs (let's say, every 5 minutes), it first gets the current account, which succeeds (and also resets the sync count) and then it tries to get PRs and fails because of the scope issue, throws an AuthenticationError, and we force it to sync.
This would cause us to sync every time the Launchpad fetches PRs which would hit our backend pretty hard and probably is not the intention, but..is it possible? If we can confirm that I am worrying for nothing, I think we are ok to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here we sync the cloud connected integration with GKDev when we face an authorization problem hoping that during the sync they respond us with the actual token.
If we see that we keep facing the same error we don't try to sync again. Instead we disconnect the integration soon letting user know that they need to take an action to reconnect.
Related to:
Follow-ups:
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses